[py] Type hint cleanup #15917
Merged
[py] Type hint cleanup #15917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selenium-ci
added
C-py
PR Code Suggestions ✨No code suggestions found for the PR. |
cgoldberg
force-pushed
the
type-hint-cleanup
branch
from
7d9e379 to
e6081cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
💥 What does this PR do?
This PR moves some types from
typingtocollections.abc, and replaces some type hints with native data types.🔄 Types of changes
PR Type
Other
Description
• Modernize type hints by moving from
typingtocollections.abc• Replace generic type hints with native Python data types
• Consolidate import statements for better organization
Changes walkthrough 📝
1 files
Replace set() with set comprehension10 files
Move Sequence from typing to collections.abcMove Sequence from typing to collections.abcReplace Dict/List with native dict/list typesMove Sequence from typing to collections.abcMove Sequence from typing to collections.abcMove Sequence from typing to collections.abcReplace Dict/Type with native dict/type hintsMove Sequence from typing to collections.abcMove Sequence from typing to collections.abcMove Sequence from typing to collections.abc